gh-152798: Revert sys.thread_info.lock to 'semaphore'/None for consistency#152994

Closed

Wojusensei wants to merge 61 commits into

python:mainfrom

Wojusensei:fix-thread-info-lock

Wojusensei commented Jul 4, 2026

Contributor

Closes gh-152798

this PR reverts the change made in GH-134747 and GH-141140 that set sys.thread_info.lock to "pymutex"

the underlying lock implementation (PyMutex) has been used since python 3.13.1 and 3.14, but changing this attribute in 3.15 was both late and misleading

this revert restores the values to match Python 3.14 behavior:

"semaphore" on POSIX platforms (linux, macOS, BSD, etc)
None on Windows and Emscripten

bedevere-app Bot commented Jul 4, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app Bot mentioned this pull request

sys.thread_info.lock was changed to "pymutex" in 3.15, even though _thread.Lock had already switched to PyMutex in 3.14 and 3.13.1 #152798

Closed

bedevere-app Bot added the awaiting review label

bedevere-app Bot commented Jul 4, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

1 similar comment

bedevere-app Bot commented Jul 4, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Wojusensei force-pushed the fix-thread-info-lock branch from 674f38b to afd14a8 Compare

July 4, 2026 08:39

bedevere-app Bot commented Jul 4, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Wojusensei force-pushed the fix-thread-info-lock branch from afd14a8 to db0ac09 Compare

July 4, 2026 08:43

bedevere-app Bot commented Jul 4, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Wojusensei commented Jul 4, 2026

Contributor Author

could a maintainer plz add the skip news label? this is a tiny internal revert that doesn't affect users

Thanks! :)

Wojusensei force-pushed the fix-thread-info-lock branch from db0ac09 to 547a1be Compare

July 4, 2026 08:49

bedevere-app Bot commented Jul 4, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.


          gh-152798: Return 'pymutex' on POSIX except Windows/WASI

bb91678

Wojusensei force-pushed the fix-thread-info-lock branch from 547a1be to bb91678 Compare

July 4, 2026 09:05

bedevere-app Bot commented Jul 4, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Wojusensei commented Jul 4, 2026

Contributor Author

the Windows test_logging and test_tkinter failures appear to be unrelated to this change :(
could a maintainer plz take a look? Thanks!~

ByteFlowing1337 commented Jul 4, 2026

Contributor

Please don't force-push.
And yes, the failure of the test_logging is unrelated -- it's reported in #84649 (comment).

Wojusensei commented Jul 4, 2026

Contributor Author

请不要用力推。是的，故障与此无关——在#84649（评论）中报告。test_logging

thank u for taking a look! i wont force push on this PR anymore. and thanks for confirming the logging test is unrelated, that's good to know :)

picnixz and others added 12 commits

July 7, 2026 19:42


          gh-152851: fix a crash when copying a BLAKE-2s/2b object (#153008)

b6160b4


          gh-153009: Fix compilation of curses on platforms that define the `…

b8ade57

…stdscr` macro (#153010)


          gh-135661: Fix abrupt closing of empty comment in HTMLParser (GH-153007)

61f111e

An abruptly closed empty comment ("<!-->" or "<!--->") no longer extends
up to a later "-->" in the same feed() call.

test_htmlparser now also feeds each string source as a single chunk, in
addition to one character at a time, to exercise different input buffering.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>


          gh-152068: Reset PyREPL Colors on prompt finish (#152108)

844dbd6

* Use ANSI Escape Codes from Colorize

* Print ANSI Color reset on finish and restore

* 📜🤖 Added by blurb_it.

* Update imports

* Update Misc/NEWS.d/next/macOS/2026-06-24-18-00-39.gh-issue-152068.ThsmJU.rst

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

* Remove news entry

* 📜🤖 Added by blurb_it.

* gh-152068: Test ANSI reset is emitted on console finish() and restore()

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>


          gh-150459: Fix SyntaxError message for from x lazy import y (#150877

612929b


          gh-151945: Fix all reference warnings and various solecisms in the `h…

f806c77

…ttp.cookiejar` docs (#152816)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <stan@python.org>


          gh-153030: Fix quadratic complexity in incremental parsing in HTMLPar…

00a98ea

…ser (GH-153031)

When an unterminated construct (e.g. a tag or comment) spanned many
feed() calls, rescanning the growing buffer and concatenating new data
onto it were both quadratic.  New data is now accumulated in a list and
only joined and parsed once enough has piled up.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>


          gh-151378: Fix unbounded memory growth when recording binary and the …

…thread is sleeping (#152089)


          gh-152718: Reject oversized table counts in the profiling binary read…

8063bb1

…er (#152719)


          Add "new in 3.16" to idlelib line (GH-152788) (#153049)

644ba17

util (line 27): root.tk_scaling method is new in 3.16.
This should have been included in PR-#152788.


          Add "new in 3.15" comments to idlelib (#153052)

45b73e0

Lazy keyword added to colorizer and test in PR-#142351.
Tested NameError hint expanded in PR-#144299.


          Remove PDF images (#145977)

1bea11a

Co-authored-by: Maciej Olko <maciej.olko@affirm.com>

Wojusensei requested review from JacobCoffee and webknjaz as code owners

July 7, 2026 11:43

python-cla-bot Bot commented Jul 7, 2026 •

edited

Loading

All commit authors signed the Contributor License Agreement.

StanFromIreland closed this

StanFromIreland removed request for a team, AA-Turner, JacobCoffee, StanFromIreland, ZeroIntensity, ambv, corona10, emmatyping, ericsnowcurrently, erlend-aasland, ezio-melotti, freakboy3742, gpshead, hugovk, iritkatriel, itamaro, lysnikolaou, markshannon, methane, pablogsal, pganssle, picnixz, savannahostrowski, terryjreedy, webknjaz and willingc

July 7, 2026 11:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review